Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test macros 2.13x3 cross compilation #475

Closed
wants to merge 3 commits into from
Closed

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Mar 5, 2024

TODO:

  • update build
    • test locally that artifacts are not broken
  • define 2.13 and 3 test cases
    • case classes
    • case classes with @BeanProperty
    • classes with default values in constructor
    • enums with parameters in any value
    • enums without parameters in any value
    • sealed traits
  • tests 2.13 converting 3 classes and vice versa
    • case classes
    • @BeanProperties as source/target
    • sealed traits to/from enums
    • default values in target type
  • documentation - describe what is possible and what isn't

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (d36030c) to head (d509669).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
+ Coverage   89.98%   90.34%   +0.35%     
==========================================
  Files         124       99      -25     
  Lines        4554     2340    -2214     
  Branches      359      191     -168     
==========================================
- Hits         4098     2114    -1984     
+ Misses        456      226     -230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok force-pushed the sandwich-tests branch 4 times, most recently from e14b222 to abd8550 Compare March 5, 2024 22:52
@MateuszKubuszok
Copy link
Member Author

Well, it seems even with workarounds "sbt sandwich" still ends up with a broken classpath. :/

@MateuszKubuszok MateuszKubuszok added the blocked Ticket cannot be implemented because it depends on another ticker or external factor label Mar 6, 2024
@MateuszKubuszok
Copy link
Member Author

Without sbt/sbt#7405 this approach would not work.

@MateuszKubuszok
Copy link
Member Author

Replaced by #647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Ticket cannot be implemented because it depends on another ticker or external factor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests and then official support for Scala 3 macros handling Scala 2.13 code and vice-versa
1 participant