Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Meson file list for src/sage/schemes/elliptic_curves #39159

Closed
wants to merge 2 commits into from

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Dec 18, 2024

Patch from #39036 (comment).

@yyyyx4 yyyyx4 force-pushed the public/fix_meson_build branch from cca49a3 to f7e40c0 Compare December 18, 2024 16:32
Copy link

github-actions bot commented Dec 18, 2024

Documentation preview for this PR (built with commit 18f610d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@yyyyx4 yyyyx4 added the p: CI Fix merged before running CI tests label Dec 18, 2024
@grhkm21
Copy link
Contributor

grhkm21 commented Dec 19, 2024

Would it be okay for this PR to add numpy_util.pxd to src/sage/modules/meson.build as well? This is according to tools/update-meson.py.

@yyyyx4
Copy link
Member Author

yyyyx4 commented Dec 19, 2024

Done.

@grhkm21 grhkm21 mentioned this pull request Dec 19, 2024
2 tasks
grhkm21 added a commit to GiacomoPope/sage that referenced this pull request Dec 19, 2024
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, but this is already fixed in #39139 (with the same changes).

@yyyyx4
Copy link
Member Author

yyyyx4 commented Dec 19, 2024

I see, thanks for the heads-up. I'll close this one and label the other one as "CI fix" instead.

@yyyyx4 yyyyx4 closed this Dec 19, 2024
@yyyyx4 yyyyx4 deleted the public/fix_meson_build branch December 19, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants