implement elliptic-curve point addition for general rings #39036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyyyx4
force-pushed
the
public/generalize_elliptic_curve_point_addition_to_rings
branch
from
3d33aa9 to
dca53c3
Compare
|
Documentation preview for this PR (built with commit f077c1a; changes) is ready! 🎉 |
vincentmacri
suggested changes
Nov 26, 2024
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
…_to_rings SageMath version 10.5, Release Date: 2024-12-04
vincentmacri
reviewed
Dec 5, 2024
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
vincentmacri
suggested changes
Dec 5, 2024
vincentmacri
suggested changes
Dec 5, 2024
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
vincentmacri
reviewed
Dec 6, 2024
|
Alright, I believe all your comments have been dealt with now. Thanks for the thorough review! |
vincentmacri
approved these changes
Dec 9, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 11, 2024
… rings
Here we revive the effort from sagemath#33228 to implement point-addition
formulas on elliptic curves over (more) general rings.
This resolves sagemath#33228.
URL: sagemath#39036
Reported by: Lorenz Panny
Reviewer(s): Lorenz Panny, Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 12, 2024
… rings
Here we revive the effort from sagemath#33228 to implement point-addition
formulas on elliptic curves over (more) general rings.
This resolves sagemath#33228.
URL: sagemath#39036
Reported by: Lorenz Panny
Reviewer(s): Lorenz Panny, Vincent Macri
|
This makes meson build fails. (I guess the fact that meson build fails all the time makes nobody want to look at it) diff --git a/src/sage/schemes/elliptic_curves/meson.build b/src/sage/schemes/elliptic_curves/meson.build
index 3448c5d1c0a..5f12079dc03 100644
--- a/src/sage/schemes/elliptic_curves/meson.build
+++ b/src/sage/schemes/elliptic_curves/meson.build
@@ -1,6 +1,7 @@
py.install_sources(
'BSD.py',
'Qcurves.py',
+ 'addition_formulas_ring.py',
'all.py',
'cardinality.py',
'cm.py',Not sure if someone already made a pull request though. |
yyyyx4
deleted the
public/generalize_elliptic_curve_point_addition_to_rings
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we revive the effort from #33228 to implement point-addition formulas on elliptic curves over (more) general rings.
This resolves #33228.