-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jupyter-packaging for conda #35627
Conversation
We don't need jupyter-packaging (explicitly, maybe only some dependencies) so conda is able to handle the dependency tree. Part of sagemath#34626. Moreover, its not working with the conda 3.11 test: https://github.com/sagemath/sage/actions/runs/4906896658/jobs/8761652608
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkoeppe Thanks for the review! Concerning the word "build dependency", jupyter-packacking is not a build dependency of sagemath (lib), it's a build dependency of some versions of some dependencies, right? Then yes, all such transitive build dependencies can be removed from the conda env. |
Yes, it's a build dependency of some jupyterlab components. |
In fact, I'm hoping that we can get rid of |
Documentation preview for this PR is ready! 🎉 |
📚 Description
We don't need jupyter-packaging (explicitly, maybe only some dependencies need it, depending on versions) so conda is able to build the dependency tree. Part of #34626. Moreover, its not working with the conda 3.11 test: https://github.com/sagemath/sage/actions/runs/4906896658/jobs/8761652608
📝 Checklist
⌛ Dependencies