-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimize conda environment #34626
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
Thanks for investigating this. That's quite a dramatic difference. Could you post a list of the packages in the difference with sizes please? |
We don't need jupyter-packaging (explicitly, maybe only some dependencies) so conda is able to handle the dependency tree. Part of sagemath#34626. Moreover, its not working with the conda 3.11 test: https://github.com/sagemath/sage/actions/runs/4906896658/jobs/8761652608
Some of these (as noted in #35627) are only build dependencies (not runtime dependencies) of some Python packages:
(None of these help explain the multi-gigabyte difference.) It may be useful to mark these packages somehow because also in the Sage distribution, we don't actually need to install them into our venv; it suffices to build wheels for them. |
…da lock files <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Using the metadata added in sagemath#37446, we automatically generate the conda environment files. This no longer makes any reference to the `conda.txt` files contained in sage-the- distribution. Thus sage-on-top-of-conda is now completely independent of sage-the-distribution (only relying on information specified by sage- the-library). In particular, after this PR is merged the `conda.txt` files could be deleted from sage-the-distribution. In particular, we no longer need to maintain the mapping of pypi packages to conda packages but instead can rely on the offical mappings maintained by the conda team (https://github.com/regro/cf-graph- countyfair/tree/master/mappings/pypi). To test: ``` pip install grayskull conda-lock python tools/update-conda.py ``` The updated conda files are committed here as well. Moreover, the `environment-dev` files have been deleted as there was only little difference between these files and some people rightfully complained that having too many files in the root folder is distracting. As a byproduct, this fixes sagemath#34626. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies - sagemath#37446: specifies additional requirements in the pyproject.toml which are used to generate the conda env files - sagemath#38983: for the update of numpy - sagemath#38982: to fix meson build <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37447 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Julian Rüth, Tobias Diez
…da lock files <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Using the metadata added in sagemath#37446, we automatically generate the conda environment files. This no longer makes any reference to the `conda.txt` files contained in sage-the- distribution. Thus sage-on-top-of-conda is now completely independent of sage-the-distribution (only relying on information specified by sage- the-library). In particular, after this PR is merged the `conda.txt` files could be deleted from sage-the-distribution. In particular, we no longer need to maintain the mapping of pypi packages to conda packages but instead can rely on the offical mappings maintained by the conda team (https://github.com/regro/cf-graph- countyfair/tree/master/mappings/pypi). To test: ``` pip install grayskull conda-lock python tools/update-conda.py ``` The updated conda files are committed here as well. Moreover, the `environment-dev` files have been deleted as there was only little difference between these files and some people rightfully complained that having too many files in the root folder is distracting. As a byproduct, this fixes sagemath#34626. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies - sagemath#37446: specifies additional requirements in the pyproject.toml which are used to generate the conda env files - sagemath#38983: for the update of numpy - sagemath#38982: to fix meson build <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37447 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Julian Rüth, Tobias Diez
The dev-conda environment contains quite a lot of packages that are not directly needed to compile or run sage, but only to compile one of sage's dependencies. Since conda already takes care of building the dependency tree (and only including runtime dependencies in it), there is no need to include the deep-dependencies in the environment file. Doing so just unnecessary bloats up the install time and size.
In fact,
du -hs /opt/conda/envs/**
showsthat the sage-dev environment is very large and there is a lot of room for improvement. The second env in the above list corresponds to the following env:
This env has been created using https://github.com/conda-incubator/conda-tree minimizing function (which only takes the leaves of the dependency tree) and then manually going through the remaining dependencies to see which ones are not needed by sage (see comments). Sage compiles within this env, but I've not yet run the doctests. I propose to include this env file directly, replacing the existing automatically generated
sage-dev
.Comments about whether the packages without any comments are used/needed are welcome.
To see which packages are still rather big, use
CC: @isuruf @dimpase @saraedum @mkoeppe @slel
Component: build
Author: Tobias Diez
Issue created by migration from https://trac.sagemath.org/ticket/34626
The text was updated successfully, but these errors were encountered: