-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularization of sagelib: Break out separate packages sagemath-environment, sagemath-repl #29941
Comments
comment:2
Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111 |
Changed keywords from none to sd111 |
comment:4
Setting new milestone based on a cursory review of ticket status, priority, and last modification date. |
This comment has been minimized.
This comment has been minimized.
Dependencies: #29865 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Author: Matthias Koeppe, ... |
comment:131
trivial merge |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:136
Not the only fail but e.g.:
|
comment:139
The failure in sage/doctest/forker.py is unrelated, fixed in #33917. |
comment:140
OK |
The distribution sagemath-environment has no dependencies and contains:
sage.env
sage.features
sage.misc.package
sage.misc.package_dir
(from Prepare sage.doctest for namespace packages #33033)sage.misc.temporary_file
(dependency onSAGE_TMP
/lazy_string
removed in sage.misc.temporary_file: Remove use of SAGE_TMP #33797)sage.misc.viewer
(The basic distributions sagemath-objects and sagemath-categories do not depend on these!)
It also includes the top-level scripts
sage
andsage-env
, and the helper scriptsage-venv-config
. This will allow users to runsage -sh
even if sagelib is not installed.To test:
The distribution sagemath-repl depends on (install-requires) sagemath-environment and sagemath-objects and contains at least the following:
sage.repl
sage.doctest
(which depends onsage.repl
)sage.misc.sage_input
sage.misc.sage_eval
It also includes scripts such as
sage-runtests
(which implementssage -t
),sage-ipython
(which is called whensage
is invoked with no arguments), etc.Of course, with nothing else installed, neither
sage -t
norsage
will work fully becausesage.all
is not available. Butsage -t
already has the option--environment
for specifying a different top-level module in which to run the doctester; we use this in the test suite of sagemath-objects and sagemath-polyhedra (#32432).To test:
Afterwards:
Note the new warning about
sage.all
.We also change all
pkgs/*/VERSION.txt
files from symlinks to regular files, updated bysage-update-version
when a new release is made. This makes it easier to cut post-versions such as9.6.rc3.post4
or dev versions such as9.6.rc4.dev1
, as was necessary during the development of this ticket. See documentation added in this ticket.Follow-ups (see Meta-ticket #29705):
setup.py
. (Refactor distributions sagemath-{objects,categories} through sagemath-{environment,repl} #33812)extras_require
"test" on sagemath-repl. (Refactor distributions sagemath-{objects,categories} through sagemath-{environment,repl} #33812)sage -help
,sage -advance
show what to install to make options work. Also show what to install on error. (#33795 comment:7)sage.misc.sage_ostools
(need to split out Cython stuff),sage.misc.cython
(?)sage_eval
work with a smaller module thansage.all
, and use this option in most uses ofsage_eval
(Meta-ticket: Remove runtime dependency on everything viasage_eval
#33802)Depends on #33797
Depends on #33016
Depends on #33799
Depends on #33801
Depends on #33803
CC: @kwankyu @tobiasdiez @kliem @orlitzky @dimpase @jhpalmieri @kiwifb
Component: refactoring
Keywords: sd111
Author: Matthias Koeppe
Branch/Commit:
3884373
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/29941
The text was updated successfully, but these errors were encountered: