Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Python 3.10 syntax in doctest introduced in #33799 #33917

Closed
mkoeppe opened this issue May 28, 2022 · 8 comments
Closed

Avoid Python 3.10 syntax in doctest introduced in #33799 #33917

mkoeppe opened this issue May 28, 2022 · 8 comments
Labels
c: python3 p: critical / 2 t: bug
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 28, 2022

Parenthesized context managers were introduced in https://docs.python.org/3/whatsnew/3.10.html#parenthesized-context-managers, we can't use it yet.

CC: @orlitzky

Component: python3

Author: Matthias Koeppe

Branch/Commit: c6fc3f3

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/33917
@mkoeppe mkoeppe added this to the sage-9.7 milestone May 28, 2022
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 28, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 28, 2022

Branch: u/mkoeppe/avoid_python_3_10_syntax_in_doctest_introduced_in__33799

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 28, 2022

New commits:

c6fc3f3src/sage/doctest/forker.py: Rewrite doctest without python 3.10 parenthesized context manager

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 28, 2022

Commit: c6fc3f3

@fchapoton
Copy link
Contributor

comment:5

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented May 29, 2022

Changed branch from u/mkoeppe/avoid_python_3_10_syntax_in_doctest_introduced_in__33799 to c6fc3f3

@vbraun vbraun closed this as completed in cda7f69 May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe