Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11: Add #[deny(unsafe_op_in_unsafe_fn)] #3121

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Sep 29, 2023

Follow-up to #3070, add #[deny(unsafe_op_in_unsafe_fn)] on the remaining platform X11, such that we can now enable it for the entirety of winit.

CC @notgull since this may impact your x11rb work?

  • Tested on all platforms changed

@madsmtm madsmtm added DS - x11 S - maintenance Repaying technical debt labels Sep 29, 2023
@madsmtm madsmtm removed the request for review from msiglreith September 29, 2023 14:25
@madsmtm madsmtm force-pushed the deny-unsafe_op_in_unsafe_fn branch from 571deaa to 78291e6 Compare September 30, 2023 13:43
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some overlap but it shouldn't be too hard to rebase over.

@madsmtm madsmtm merged commit af247ea into master Sep 30, 2023
@madsmtm madsmtm deleted the deny-unsafe_op_in_unsafe_fn branch September 30, 2023 19:43
kchibisov pushed a commit to kchibisov/winit that referenced this pull request Oct 17, 2023
* X11: Add #[deny(unsafe_op_in_unsafe_fn)]

* Enable #![deny(unsafe_op_in_unsafe_fn)] everywhere
kchibisov pushed a commit that referenced this pull request Oct 21, 2023
* X11: Add #[deny(unsafe_op_in_unsafe_fn)]

* Enable #![deny(unsafe_op_in_unsafe_fn)] everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DS - x11 S - maintenance Repaying technical debt
Development

Successfully merging this pull request may close these issues.

2 participants