Windows: Add #[deny(unsafe_op_in_unsafe_fn)]
#3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiglreith
approved these changes
Sep 13, 2023
|
@madsmtm will need a rebase. |
madsmtm
force-pushed
the
windows-deny-unsafe_op_in_unsafe_fn
branch
from
fdca191 to
6e68a96
Compare
1 task
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Oct 17, 2023
kchibisov
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this does increase the verbosity, it also greatly helps in auditing which parts of the codebase is actually
unsafe, and thus need extra scrutiny. My plan is to add it to the entirety ofwinit.The lint is even stated in the documentation for the keyword
unsafe, and the desire is to make it warn by default at some point in the far future.Related: What I'm seeing from applying this lint is that a lot of the Windows backend is
unsafe, I think we should consider working on improving that.