forked from project-chip/connectedhomeip
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for WiFi band scan results #326
Draft
rosahay-silabs
wants to merge
4
commits into
feature/add-wifi-band-support
Choose a base branch
from
feature/add-band-scan-results
base: feature/add-wifi-band-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
eb55053
Add `WiFiBandEnum` to scan callback struct
brosahay 9b8d5fb
Fix typo in variable name for scanned SSID length in BackgroundScanCa…
brosahay 1a5668c
Add WiFiBandEnum usage to WiFi interface implementations
brosahay eb1fcd3
Add WiFi band information to scan response in SlWiFiDriver
brosahay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,6 +53,8 @@ constexpr size_t kWifiMacAddressLength = 6; | |
#define WFX_MAX_SSID_LENGTH (32) | ||
#define MAX_JOIN_RETRIES_COUNT (5) | ||
|
||
using WiFiBandEnum = chip::app::Clusters::NetworkCommissioning::WiFiBandEnum; | ||
|
||
/* Note that these are same as RSI_security */ | ||
typedef enum | ||
{ | ||
|
@@ -73,6 +75,7 @@ typedef struct wfx_wifi_scan_result | |
uint8_t bssid[kWifiMacAddressLength]; | ||
uint8_t chan; | ||
int16_t rssi; /* I suspect this is in dBm - so signed */ | ||
WiFiBandEnum wiFiBand; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the plan to clean up this structure in this PR or in a follow up? When we modify the legacy interface elements, we should refactor them as we go. |
||
} wfx_wifi_scan_result_t; | ||
using ScanCallback = void (*)(wfx_wifi_scan_result_t *); | ||
|
||
|
@@ -412,7 +415,6 @@ class WifiInterface | |
*/ | ||
virtual void CancelScanNetworks() = 0; | ||
|
||
using WiFiBandEnum = app::Clusters::NetworkCommissioning::WiFiBandEnum; | ||
/** | ||
* @brief Provide all the frequency bands supported by the Wi-Fi interface. | ||
* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We avoid as much as possible to use
using
in a header file since this will propagate to any file that includes the header.We should use the long name here.