Adds support for WiFi band scan results #326
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +53,8 @@ constexpr size_t kWifiMacAddressLength = 6; | |||
| #define WFX_MAX_SSID_LENGTH (32) | |||
| #define MAX_JOIN_RETRIES_COUNT (5) | |||
|
|
|||
| using WiFiBandEnum = chip::app::Clusters::NetworkCommissioning::WiFiBandEnum; | |||
There was a problem hiding this comment.
We avoid as much as possible to use using in a header file since this will propagate to any file that includes the header.
We should use the long name here.
| @@ -73,6 +75,7 @@ typedef struct wfx_wifi_scan_result | |||
| uint8_t bssid[kWifiMacAddressLength]; | |||
| uint8_t chan; | |||
| int16_t rssi; /* I suspect this is in dBm - so signed */ | |||
| WiFiBandEnum wiFiBand; | |||
There was a problem hiding this comment.
Is the plan to clean up this structure in this PR or in a follow up? When we modify the legacy interface elements, we should refactor them as we go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing