-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds GetSupportedWiFiBandsMask
API
#325
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -16,7 +16,9 @@ | |||||
*/ | ||||||
#pragma once | ||||||
|
||||||
#include <app-common/zap-generated/cluster-enums.h> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This include will also be necessary in the other PR (but i think it gets merged in this branch anywais) |
||||||
#include <app/icd/server/ICDServerConfig.h> | ||||||
|
||||||
#include <array> | ||||||
#include <cmsis_os2.h> | ||||||
#include <lib/support/BitFlags.h> | ||||||
|
@@ -410,6 +412,20 @@ class WifiInterface | |||||
*/ | ||||||
virtual void CancelScanNetworks() = 0; | ||||||
|
||||||
using WiFiBandEnum = app::Clusters::NetworkCommissioning::WiFiBandEnum; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should avoid as much as possible of having a using in a header file. |
||||||
/** | ||||||
* @brief Provide all the frequency bands supported by the Wi-Fi interface. | ||||||
* | ||||||
* The default implementation returns the 2.4 GHz band support. | ||||||
* | ||||||
* @return a bitmask of supported Wi-Fi bands where each bit is associated with a WiFiBandEnum value. | ||||||
*/ | ||||||
virtual uint32_t _GetSupportedWiFiBandsMask() const | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{ | ||||||
// Default to 2.4G support only | ||||||
return static_cast<uint32_t>(1UL << chip::to_underlying(WiFiBandEnum::k2g4)); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we know the bitmap expected mapping? Where is this defined? |
||||||
} | ||||||
|
||||||
protected: | ||||||
/** | ||||||
* @brief Function notifies the PlatformManager that an IPv6 event occured on the WiFi interface. | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So currently we don't use this new method?