Adds GetSupportedWiFiBandsMask API
#325
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -410,6 +412,20 @@ class WifiInterface | |||
| */ | |||
| virtual void CancelScanNetworks() = 0; | |||
|
|
|||
| using WiFiBandEnum = app::Clusters::NetworkCommissioning::WiFiBandEnum; | |||
There was a problem hiding this comment.
We should avoid as much as possible of having a using in a header file.
| * | ||
| * @return a bitmask of supported Wi-Fi bands where each bit is associated with a WiFiBandEnum value. | ||
| */ | ||
| virtual uint32_t _GetSupportedWiFiBandsMask() const |
There was a problem hiding this comment.
Suggested change
| virtual uint32_t _GetSupportedWiFiBandsMask() const | |
| virtual uint32_t GetSupportedWiFiBandsMask() const |
| @@ -16,7 +16,9 @@ | |||
| */ | |||
| #pragma once | |||
|
|
|||
| #include <app-common/zap-generated/cluster-enums.h> | |||
There was a problem hiding this comment.
This include will also be necessary in the other PR (but i think it gets merged in this branch anywais)
| @@ -258,6 +258,11 @@ chip::BitFlags<WiFiSecurity> SlWiFiDriver::ConvertSecuritytype(wfx_sec_t securit | |||
| return securityType; | |||
| } | |||
|
|
|||
| uint32_t SlWiFiDriver::GetSupportedWiFiBandsMask() const | |||
There was a problem hiding this comment.
So currently we don't use this new method?
| virtual uint32_t _GetSupportedWiFiBandsMask() const | ||
| { | ||
| // Default to 2.4G support only | ||
| return static_cast<uint32_t>(1UL << chip::to_underlying(WiFiBandEnum::k2g4)); |
There was a problem hiding this comment.
Do we know the bitmap expected mapping? Where is this defined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Checked build for different NCP combinations and for SoC.