Skip to content
This repository was archived by the owner on Jun 10, 2021. It is now read-only.

Move metrics_statistics_msgs to rcl_interfaces #135

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

prajakta-gokhale
Copy link
Member

@prajakta-gokhale prajakta-gokhale commented Apr 15, 2020

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
@prajakta-gokhale prajakta-gokhale force-pushed the prajaktg/remove-msgs-package branch from 98fed32 to fec82db Compare April 17, 2020 01:57
@prajakta-gokhale prajakta-gokhale changed the title Move metrics_statistics_msgs to its own repo Move metrics_statistics_msgs to rcl_interfaces Apr 17, 2020
@prajakta-gokhale prajakta-gokhale marked this pull request as ready for review April 17, 2020 02:20
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #135 into master will increase coverage by 7.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   20.63%   28.07%   +7.43%     
==========================================
  Files         100       70      -30     
  Lines        4187     2654    -1533     
  Branches     1076     1063      -13     
==========================================
- Hits          864      745     -119     
+ Misses       2338      928    -1410     
+ Partials      985      981       -4     
Flag Coverage Δ
#unittests 28.07% <0.00%> (+7.43%) ⬆️
Impacted Files Coverage Δ
...ollector/collector/generate_statistics_message.cpp 62.50% <ø> (ø)
...m_metrics_collector/linux_cpu_measurement_node.cpp 33.33% <ø> (ø)
...etrics_collector/linux_memory_measurement_node.cpp 38.46% <ø> (ø)
...em_metrics_collector/metrics_message_publisher.hpp 100.00% <ø> (ø)
...em_metrics_collector/periodic_measurement_node.cpp 49.45% <ø> (ø)
...em_metrics_collector/periodic_measurement_node.hpp 100.00% <ø> (ø)
...atistics_collector/subscriber_topic_statistics.hpp 51.28% <0.00%> (ø)
...r/test/system_metrics_collector/test_functions.hpp 54.83% <ø> (ø)
...m_metrics_collector/test_linux_cpu_measurement.cpp 18.26% <ø> (ø)
...etrics_collector/test_linux_memory_measurement.cpp 20.68% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049054b...fec82db. Read the comment docs.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prajakta-gokhale prajakta-gokhale merged commit 8ece291 into master Apr 17, 2020
@prajakta-gokhale prajakta-gokhale deleted the prajaktg/remove-msgs-package branch April 17, 2020 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants