Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Codecov CI action fails on PRs from forks #132

Closed
emersonknapp opened this issue Feb 4, 2020 · 4 comments
Closed

Codecov CI action fails on PRs from forks #132

emersonknapp opened this issue Feb 4, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@emersonknapp
Copy link
Contributor

emersonknapp commented Feb 4, 2020

Description

When a Pull Request comes in from a fork, it can't access the secret codecov token, so the CI fails to upload codecov results and returns a failure. This was observed here: #131

Latest news is that there is a GitHub Actions API released today, and the codecov action is working to implement a solution - see codecov/codecov-action#29

For now, this issue can track that progress.

Expected Behavior

  • PRs from forks can upload codecov results

Actual Behavior

  • PRs from forks fail CI on the tasks that try to upload to codecov

To Reproduce

  • Open a PR from a fork of this repo

System (please complete the following information)

N/A

Additional context

Codecov is working on "Tokenless uploads" https://community.codecov.io/t/whitelist-github-action-servers-to-upload-without-a-token/491/15

@prajakta-gokhale
Copy link
Member

prajakta-gokhale commented Feb 22, 2020

This is true for all repos using action-ros-ci. Similar issue: ros-tooling/action-ros-ci#56.

@emersonknapp
Copy link
Contributor Author

According to codecov/codecov-action#29 (comment) we should have some option available in the next week or so.

@emersonknapp emersonknapp self-assigned this Mar 5, 2020
@emersonknapp
Copy link
Contributor Author

Codecov action "tokenless uploads" have been enabled - check if it works

@emersonknapp
Copy link
Contributor Author

This is now working - see report on #171 - accurately reported reduced coverage

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants