Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql-cdc): validate mysql version less then 8.4 #17728

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Jul 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

MySQL 8.4 introduces some breaking changes: https://dev.mysql.com/doc/relnotes/mysql/8.4/en/news-8-4-0.html#mysqld-8-4-0-deprecation-removal

We may support MySQL 8.4 in future, this pr adds a check to validate the mysql version.

#16701

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor Author

StrikeW commented Jul 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @StrikeW and the rest of your teammates on Graphite Graphite

@StrikeW StrikeW changed the title check mysql version fix(mysql-cdc): validate mysql version less then 8.4 Jul 18, 2024
@github-actions github-actions bot added the type/fix Bug fix label Jul 18, 2024
@StrikeW StrikeW marked this pull request as ready for review July 18, 2024 03:16
@StrikeW StrikeW requested review from yuhao-su and cyliu0 July 18, 2024 03:39
@cyliu0
Copy link
Collaborator

cyliu0 commented Jul 18, 2024

/test

@StrikeW StrikeW added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 0883df5 Jul 18, 2024
33 of 37 checks passed
@StrikeW StrikeW deleted the siyuan/07-18-check_mysql_version branch July 18, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants