fix(mysql-cdc): validate mysql version less then 8.4 (#17728)

Co-authored-by: Chengyou Liu <35356271+cyliu0@users.noreply.github.com>
risingwavelabs · Jul 18, 2024 · 0883df5 · 0883df5
1 parent 3328025
commit 0883df5
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/...onnector-service/src/main/java/com/risingwave/connector/source/common/MySqlValidator.java b/...onnector-service/src/main/java/com/risingwave/connector/source/common/MySqlValidator.java
@@ -63,7 +63,15 @@ public MySqlValidator(
     @Override
     public void validateDbConfig() {
         try {
-            // TODO: check database server version
+            // Check whether MySQL version is less than 8.4,
+            // since MySQL 8.4 introduces some breaking changes:
+            // https://dev.mysql.com/doc/relnotes/mysql/8.4/en/news-8-4-0.html#mysqld-8-4-0-deprecation-removal
+            var major = jdbcConnection.getMetaData().getDatabaseMajorVersion();
+            var minor = jdbcConnection.getMetaData().getDatabaseMinorVersion();
+
+            if ((major > 8) || (major == 8 && minor >= 4)) {
+                throw ValidatorUtils.failedPrecondition("MySQL version should be less than 8.4");
+            }
             validateBinlogConfig();
         } catch (SQLException e) {
             throw ValidatorUtils.internalError(e.getMessage());