-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explain): use Distill
for explain
#10492
Conversation
append_only reuse force lt owali More union finish impls
Regarding the |
Codecov Report
@@ Coverage Diff @@
## main #10492 +/- ##
==========================================
+ Coverage 70.23% 70.42% +0.18%
==========================================
Files 1269 1269
Lines 217030 217016 -14
==========================================
+ Hits 152432 152833 +401
+ Misses 64598 64183 -415
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 66 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very clean to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR replaces the main usage of
Display
withDistill
.