Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explain): use Distill for explain #10492

Merged
merged 12 commits into from
Jun 25, 2023
Merged

feat(explain): use Distill for explain #10492

merged 12 commits into from
Jun 25, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jun 23, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR replaces the main usage of Display with Distill.

@ice1000 ice1000 requested review from st1page and jon-chuang June 23, 2023 03:38
@github-actions github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Jun 23, 2023
@ice1000
Copy link
Contributor Author

ice1000 commented Jun 23, 2023

Regarding the diffs and spaces, I think there can be a mode in pretty-xmlish to avoid those. Let me think about it.

@ice1000
Copy link
Contributor Author

ice1000 commented Jun 24, 2023

I've done a reduction from
image
to
image

Very satisfied!!

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #10492 (dd7cffd) into main (5d899ac) will increase coverage by 0.18%.
The diff coverage is 65.95%.

@@            Coverage Diff             @@
##             main   #10492      +/-   ##
==========================================
+ Coverage   70.23%   70.42%   +0.18%     
==========================================
  Files        1269     1269              
  Lines      217030   217016      -14     
==========================================
+ Hits       152432   152833     +401     
+ Misses      64598    64183     -415     
Flag Coverage Δ
rust 70.42% <65.95%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/create_index.rs 88.06% <0.00%> (ø)
src/frontend/src/handler/create_mv.rs 93.08% <0.00%> (ø)
src/frontend/src/handler/create_sink.rs 94.93% <0.00%> (ø)
src/frontend/src/handler/query.rs 27.24% <0.00%> (ø)
src/frontend/src/optimizer/heuristic_optimizer.rs 89.85% <0.00%> (ø)
.../src/optimizer/plan_visitor/input_ref_validator.rs 81.96% <0.00%> (ø)
src/frontend/src/optimizer/mod.rs 92.17% <55.55%> (ø)
src/frontend/src/optimizer/logical_optimization.rs 96.08% <58.33%> (ø)
src/frontend/planner_test/src/lib.rs 86.83% <100.00%> (ø)
src/frontend/src/handler/explain.rs 69.64% <100.00%> (+0.41%) ⬆️
... and 2 more

... and 66 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very clean to me

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ice1000 ice1000 added this pull request to the merge queue Jun 25, 2023
Merged via the queue into main with commit ce86140 Jun 25, 2023
@ice1000 ice1000 deleted the tesla/dio branch June 25, 2023 05:57
@CharlieSYH CharlieSYH added the 📖✗ No user documentation is needed. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✗ No user documentation is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants