Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Better pretty printing for SQL explain #42

Merged
merged 3 commits into from
Jul 7, 2023
Merged

RFC: Better pretty printing for SQL explain #42

merged 3 commits into from
Jul 7, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jan 28, 2023 •
edited
Loading

xxchan
xxchan approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your implementation schedule? 🤩

@ice1000
Copy link
Contributor Author

ice1000 commented Feb 17, 2023

What's your implementation schedule? 🤩

I have a very important thing to do in this month and I'll start right in March

@ice1000 ice1000 mentioned this pull request Mar 15, 2023
Merged
6 tasks
@ice1000
Copy link
Contributor Author

ice1000 commented Mar 19, 2023

Merge? Since risingwavelabs/risingwave#8576 is merged

@xxchan
Copy link
Member

xxchan commented Mar 20, 2023

Only stream_dist_plan is changed now, what about other plans? 👀

@ice1000
Copy link
Contributor Author

ice1000 commented Mar 20, 2023

Only stream_dist_plan is changed now, what about other plans? 👀

I will do them soon. Okay it seems that you're asking me to overhaul everything before I can get this merged 🤣

@ice1000
Copy link
Contributor Author

ice1000 commented Jul 7, 2023

Only stream_dist_plan is changed now, what about other plans? 👀

Should we merge this now?

@ice1000
Copy link
Contributor Author

ice1000 commented Jul 7, 2023

Since the PRs are all merged I think it's good to go

@ice1000 ice1000 merged commit dc7e4f4 into main Jul 7, 2023
@ice1000 ice1000 deleted the tiz/pretty branch July 7, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ice1000 @xxchan