Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back rr.ImageEncoded for backwards compatibility #7096

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 7, 2024

What

I need someone with Python skills to finish this.

Note that these are revived things:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Deployed docs

Commit Link
35375ed https://landing-8sneny5ja-rerun.vercel.app/docs

ImageFormat.YUY2 = YUY2


def ImageEncoded(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageEncoded used to be a class, but is now a function so that it can return either an Image or an EncodedImage. Maybe a Python guru has a better idea?


"""

warnings.warn(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning makes the unit tests fail. I have no idea how to fix that.

@jleibs jleibs marked this pull request as ready for review August 7, 2024 18:45
@jleibs jleibs force-pushed the emilk/image_encoded.py branch from 9a8282a to 35375ed Compare August 7, 2024 18:46
@jleibs jleibs merged commit 47d5331 into main Aug 7, 2024
34 checks passed
@jleibs jleibs deleted the emilk/image_encoded.py branch August 7, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back old rr.ImageEncoded helper to guide users
2 participants