Introduce new ImageFormat component #7083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed docs
|
jleibs
force-pushed
the
jleibs/image_format
branch
2 times, most recently
from
1ef2d25 to
682042e
Compare
6 tasks
jleibs
force-pushed
the
jleibs/image_format
branch
from
afa8b5a to
9cc8583
Compare
jleibs
commented
Aug 7, 2024
emilk
reviewed
Aug 7, 2024
emilk
reviewed
Aug 7, 2024
emilk
reviewed
Aug 7, 2024
emilk
reviewed
Aug 7, 2024
crates/viewer/re_space_view_spatial/src/max_image_dimension_subscriber.rs
Outdated
Show resolved
Hide resolved
emilk
reviewed
Aug 7, 2024
| @@ -73,27 +77,26 @@ impl Image { | |||
| /// | |||
| /// See also [`Self::from_color_model_and_tensor`]. | |||
| pub fn from_pixel_format( | |||
| resolution: impl Into<Resolution2D>, | |||
| [width, height]: [u32; 2], | |||
There was a problem hiding this comment.
We should maybe do impl Into<[u32; 2]> here and below
jleibs
commented
Aug 7, 2024
jleibs
changed the title
jleibs
added a commit
that referenced
this pull request
Aug 7, 2024
### What * Closes #7086 * Should maybe wait for #7083 I need someone with Python skills to finish this. Note that these are revived things: * https://ref.rerun.io/docs/python/0.17.0/common/enums/#rerun.ImageFormat * https://ref.rerun.io/docs/python/0.17.0/common/image_helpers/ ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7096?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7096?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7096) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Imagecomponents into onestruct ImageFormat#7051Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.