Move context menu to new re_context_menu crate
#6423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
🚜 refactor
abey79
commented
May 23, 2024
| @@ -28,7 +29,6 @@ re_tracing.workspace = true | |||
| re_types.workspace = true | |||
| re_ui.workspace = true | |||
| re_viewer_context.workspace = true | |||
| re_viewport.workspace = true # TODO(#6414): remove this dependency in favor of re_context_menu when it exists | |||
There was a problem hiding this comment.
glad to see that one gone :)
abey79
commented
May 23, 2024
| } | ||
| } | ||
|
|
||
| impl<'a> SpaceViewClassExt<'a> for dyn SpaceViewClass + 'a {} |
There was a problem hiding this comment.
those fancy lifetime were necessary to address a weird borrow checker error 🤷🏻
5 tasks
abey79
added a commit
that referenced
this pull request
May 27, 2024
### What - Fixes #6415 Straightforward refactor overall. Made two calls: - Create a `ui` sub-module in `re_viewport_blueprint` to host the `add_space_view_or_container` modal (used by both the blueprint tree and the selection panel). - Moved down two small utility functions in `re_viewer_context` (in `lib.rs`). - There was a weird double-buffering of the drop target container ID going through `TreeAction`. This is gone in favour of a much simpler approach (still double-buffered though). (Chained to #6423)  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6427?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6427?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6427) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Mostly pure refactor, except for moving
determine_visualizable_entitiesto aSpaceViewClassextension trait.Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.