Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scalar multiple plots example for C++ #3914

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 18, 2023

What

What it says on the tin!
Tried using sin + cast instead of sinf, but still couldn't get the results to match with Rust sadly 🤷

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added examples Issues relating to the Rerun examples 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 18, 2023
@emilk
Copy link
Member

emilk commented Oct 18, 2023

Tried using sin + cast instead of sinf, but still couldn't get the results to match with Rust sadly 🤷

We should make the comparison tool allow for a few bits of error in our floats

@Wumpf Wumpf merged commit 15902d2 into main Oct 18, 2023
@Wumpf Wumpf deleted the andreas/cpp/scalar_multiple_plots branch October 18, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants