Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing code-examples for C++ #3751

Closed
Tracked by #2919
Wumpf opened this issue Oct 10, 2023 · 1 comment
Closed
Tracked by #2919

Implement missing code-examples for C++ #3751

Wumpf opened this issue Oct 10, 2023 · 1 comment
Labels
🌊 C++ API C/C++ API specific 📖 documentation Improvements or additions to documentation
Milestone
0.10 C++

Comments

@Wumpf
Copy link
Member

Wumpf commented Oct 10, 2023 •
edited by emilk
Loading

a few missing. If it's too many to do on one go put them here.
There are a few todo's scattered that may give rise to more tasks

This will also mean making sure the interfaces are good (expand our _ext.cpp files)
@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation 🌊 C++ API C/C++ API specific labels Oct 10, 2023
@Wumpf Wumpf added this to the 0.10 C++ milestone Oct 10, 2023
@Wumpf Wumpf mentioned this issue Oct 10, 2023
Closed
33 tasks
@emilk emilk changed the title Polish C++ api code examples and fill gaps Implement missing code-examples for C++ Oct 16, 2023
This was referenced Oct 18, 2023
Merged
Merged
Wumpf added a commit that referenced this issue Oct 18, 2023
@Wumpf
Implement scalar multiple plots example for C++ (#3914)
15902d2 
### What

* part of  #3751

What it says on the tin!
Tried using `sin` + cast instead of `sinf`, but still couldn't get the
results to match with Rust sadly 🤷

<img width="1232" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/4bd7d025-3945-45b8-8215-5196c085d0fd">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3914) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3914)
- [Docs
preview](https://rerun.io/preview/81044e7460bf76c1c3093e929e55b7a499c9f24f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/81044e7460bf76c1c3093e929e55b7a499c9f24f/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Wumpf added a commit that referenced this issue Oct 18, 2023
@Wumpf
C++ example for asset3d_out_of_tree and related cleanup (#3913)
2b7baef 
### What

* part of  #3751
* use Result for from_file
* move heavy impl to c++ (codegen TODO: need to not leak heavy headers
into public; make putting headers in _ext opt-in!)
* (unrelated) rolled back some local vscode cmake settings that weren't
that great after all

<img width="1269" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/f98de83b-1f29-48a9-8703-39e05a9a4b26">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3913) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3913)
- [Docs
preview](https://rerun.io/preview/317506389d3fc84a38d3c60db7843d35875898c2/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/317506389d3fc84a38d3c60db7843d35875898c2/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@Wumpf
Copy link
Member Author

Wumpf commented Oct 18, 2023

We're pretty much done. Only relevant things left are:

  • custom_data
    • can do, but serialization shape is a bit in flux. need to nail down things a bit. We can punt on this.
  • quick_start_connect
    • required as part of docs

Others:

  • any_values
    • type not implemented in Rust and C++
  • extra_values
    • special api for python any_Values integration
  • image_advanced
    • demonstratesextra python features
  • log_line
    • looks kinda broken, where is this used?
  • text_log_integration
    • there's no standard text log in C++. Pretty much out of scope

@Wumpf Wumpf closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific 📖 documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.10 C++
Development

No branches or pull requests
1 participant
@Wumpf