Remove legacy DisconnectedSpace
#2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🐍 Python API
teh-cmc
changed the title
DisconnectedSpaceDisconnectedSpace
teh-cmc
changed the base branch from
main
to
cmc/roundtrippable_disconnected_transform
teh-cmc
force-pushed
the
cmc/roundtrippable_disconnected_transform
branch
2 times, most recently
from
7a55807 to
aaedde5
Compare
teh-cmc
force-pushed
the
cmc/goodbye_old_disconnected_space
branch
2 times, most recently
from
35782fd to
06cd869
Compare
teh-cmc
force-pushed
the
cmc/roundtrippable_disconnected_transform
branch
from
b3ea863 to
31078e8
Compare
teh-cmc
force-pushed
the
cmc/goodbye_old_disconnected_space
branch
from
ca86bf8 to
4c3292d
Compare
Base automatically changed from
cmc/roundtrippable_disconnected_transform
to
main
July 28, 2023 11:14
teh-cmc
added a commit
that referenced
this pull request
Jul 28, 2023
- Use `DisconnectedSpace`'s inner boolean as more than an Arrow hack. This enhances both the consistency and usability of the API, as now reverting a disconnection is just a simple matter of logging the inverse operation: `rr.log(rr.DisconnectedSpace(false))`. - Remove long deprecated `rr.log_unknown_transform` API. Requires #2835 ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2836) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2836) - [Docs preview](https://rerun.io/preview/pr%3Acmc%2Fuse_dem_bools/docs) - [Examples preview](https://rerun.io/preview/pr%3Acmc%2Fuse_dem_bools/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old
DisconnectedSpaceentirely.The legacy
rr.disconnected_space()have been rewritten in terms of the newDisconnectedSpacearchetype.Part of #2791
Requires #2833
What
Checklist