Implement roundtrip-ready DisconnectedSpace archetype
#2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🐍 Python API
teh-cmc
force-pushed
the
cmc/roundtrippable_disconnected_transform
branch
2 times, most recently
from
23bb814 to
56397e9
Compare
3 tasks
teh-cmc
force-pushed
the
cmc/roundtrippable_disconnected_transform
branch
2 times, most recently
from
7a55807 to
aaedde5
Compare
Wumpf
approved these changes
Jul 28, 2023
Comment on lines
+3
to
+7
| impl From<bool> for DisconnectedSpace { | ||
| fn from(b: bool) -> Self { | ||
| Self(b) | ||
| } | ||
| } |
There was a problem hiding this comment.
are you sure? true.into() seems wild to me
I'd like to have the default on it to be true though, i.e. DisconnectedSpace::default() should give set true
There was a problem hiding this comment.
The UX on the API would be pretty awful otherwise because this is both an archetype and a component within that archetype (rerun::DisconnectedSpace::new(rerun::datatypes::DisconnectedSpace(true)) vs rerun::DisconnectedSpace::new(true).
I can add a default value yep.
teh-cmc
force-pushed
the
cmc/roundtrippable_disconnected_transform
branch
from
b3ea863 to
31078e8
Compare
|
Addressed comments from #2768 as well! |
teh-cmc
added a commit
that referenced
this pull request
Jul 28, 2023
This PR removes the old `DisconnectedSpace` entirely. The legacy `rr.disconnected_space()` have been rewritten in terms of the new `DisconnectedSpace` archetype. --- Part of #2791 Requires #2833 ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2835) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2835) - [Docs preview](https://rerun.io/preview/pr%3Acmc%2Fgoodbye_old_disconnected_space/docs) - [Examples preview](https://rerun.io/preview/pr%3Acmc%2Fgoodbye_old_disconnected_space/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the title says.
This does not migrate off of the legacy
DisconnectedSpace, that's for a future PR.Part of #2791
What
Checklist