-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need URLs differentiated by language #38
Comments
Languages are added to the URLs |
The good news is that you've implemented this. The bad news is... I'm not at all convinced you've got the right URLs in there:
What is required is an alternation between https://www.bipm.org/en/committees/ci/cipm/42-1948 and https://www.bipm.org/fr/committees/ci/cipm/42-1948 . The two provided links to https://raw.githubusercontent.com/metanorma/bipm-data-outcomes/main/cipm/meetings-en/meeting-42.yml and https://raw.githubusercontent.com/metanorma/bipm-data-outcomes/main/cipm/meetings-fr/meeting-42.yml cannot be inserted into the brochure as links. The expectation in Metanorma is that any URI to be used to link to from a bibliographic citation, overriding the internal link to the bibliography, is of type "citation". So I expect to see:
|
@opoudjis is correct here, we need the correct URIs for the original pages at bipm.org: This is the English page: The corresponding French link is missing (they are available at bipm-data-outcomes). |
@andrew2net the implementation here is incomplete, we also need the "other" URL to be in French: |
Note that in
the second link is meant to be https://www.bipm.org/en/committees/cc/cctf/5-1970 !! Please double check. The bulk of references seem to be working as requested. Thank you! |
@opoudjis it seems the source has the wrong link https://github.com/metanorma/bipm-data-outcomes/blob/55bba1f2de0e4fce665dcd3cfc341db5ca879f38/cctf/meetings-fr/meeting-5.yml#L7 |
If a bibitem has two URLs, that are differentiated by language, add "language" as an attribute to them alongside "type", so that I can select as appropriate. This is the same behaviour already implemented for bibitem titles.
Needed for metanorma/bipm-si-brochure#192
The text was updated successfully, but these errors were encountered: