Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIPM final review: Links to BIPM outcomes should follow document language #192

Closed
ronaldtse opened this issue Sep 15, 2022 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

From BIPM Janet Miles:

In the links to the Resolutions on the BIPM website, for the French texts the “/en/” in the link should be changed to “/fr/”.

This refers to:

Right now, Relaton does not to provide links for both languages:

bipm-data-outcomes already provides both language-specific links:

metadata:
  title: 42e réunion du CIPM
  identifier: '42'
  date: '1948-10-22'
  source: BIPM - Pavillon de Breteuil
  url: https://www.bipm.org/fr/committees/ci/cipm/42-1948

This requires some change in the way Metanorma integrates with Relaton.
Metanorma also needs to include the language-specific link that is intended for the document language.

@ronaldtse ronaldtse added the bug Something isn't working label Sep 15, 2022
@ronaldtse ronaldtse moved this to 🆕 New in Metanorma Sep 15, 2022
@ronaldtse ronaldtse changed the title BIPM final review: BIPM outcome links should follow document language BIPM final review: Links to BIPM outcomes should follow document language Sep 15, 2022
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Sep 15, 2022
@ronaldtse ronaldtse added this to the Final review complete milestone Sep 17, 2022
@opoudjis opoudjis moved this from 🌋 Urgent to 🏗 In progress in Metanorma Sep 19, 2022
@opoudjis
Copy link
Contributor

This requires the URLs to be differentiated by language, just as relaton titles are, so that I can select on one.

@opoudjis opoudjis moved this from 🏗 In progress to On hold in Metanorma Sep 22, 2022
@opoudjis opoudjis moved this from On hold to 🏗 In progress in Metanorma Sep 25, 2022
@opoudjis
Copy link
Contributor

Implementing the selector, but the relaton record is wrong, so it will not work until the relaton record is corrected. The langauge-specific URIs need to be provided for both languages and be of type "citation". URI with type "src" are not external links that can be linked to from documents (and the language-specific URIs so coded are raw YAML, they are actually "src".)

@opoudjis
Copy link
Contributor

isodoc-i18n processing of XML fragments was buggy: was using HTML parser instead of XML parser.

opoudjis added a commit to metanorma/isodoc-i18n that referenced this issue Sep 27, 2022
opoudjis added a commit to metanorma/isodoc that referenced this issue Sep 27, 2022
@opoudjis
Copy link
Contributor

Waiting on debugging of relaton/relaton-bipm#38

@opoudjis
Copy link
Contributor

Confirmed working (once I clear out the relaton cache folder!)

Repository owner moved this from 🏗 In progress to ✅ Done in Metanorma Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants