Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Data Science Projects page #583
Add tests for Data Science Projects page #583
Changes from 63 commits
19e4665
958a492
77aa3a9
ed684de
9ad6738
01486bb
4334b08
5abfca4
4035274
3f40004
f21a4c4
784b548
d27bdd9
51881d1
9e65d18
93c7fa0
e4dca43
d54e84b
dc0a12a
e368e01
f6d2fc6
b62c2b0
eaa54eb
487a13f
6419394
b4ba2ed
47ec0cf
6948108
ff20239
9e147bd
0840cc8
df7524d
e9a4981
ff2aef9
607bd79
70434ae
5005d8c
be6e9cb
969856e
6ccb399
623e85a
f9034c5
88aea39
3bea1f7
ebbdd66
5fe02ed
50bced5
f9f4bed
9337332
3f15342
f5e48d1
67260c7
9ec1168
2ef1b41
db48a20
9bf9b85
8e72894
a6a2c1d
e6d4a8a
11ea825
6697c63
b11c771
f2a5e35
8fbe979
bf47e3e
2f714a1
bb321ac
9e88ac4
a8aeccf
89af893
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other keywords ${name} is called ${dc_name}. I think it could be used here too. Also it could be ${dc_type}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, sorry for the mixed approach. I thought to spare character and improve readability/development to remove the prefix where not needed. So for example if a kw is called "Data Connection Is Listed" the ${name} argument cannot be anything else than th data connection name.
Where the prefix is added, like in "Create S3 Data connection" is to avoid ambiguity because there are many arguments. Same approach applied with storages for example. While workbench resource file was the first one created and I didn't follow the same rule. Changing it now it's very error-prone process IMO.
If you all prefer me to change it, I can do in another PR if you don't mind since we need these tests for validating 1.19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter could be
${dc_name}
. Is${press_cancel}
needed (it could be just passed false when calling the other keyword)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about the ${dc_name}, pls read the comment above #583 (comment)
${press_cancel} is needed only for specific tests, so I thought these keywords will be re-used for other scenarios (e.g., model serving), then it would spare an argument (very likely always set to FALSE) to the developer who is gonna them