Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Data Science Projects page #583

Merged
merged 70 commits into from
Nov 23, 2022
Merged

Add tests for Data Science Projects page #583

merged 70 commits into from
Nov 23, 2022

Conversation

bdattoma
Copy link
Contributor

Initial testing for the upcoming feature. Tests will be developed incrementally based on feature development.

@bdattoma bdattoma added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) do not merge Do not merge this yet please labels Sep 30, 2022
@bdattoma bdattoma self-assigned this Sep 30, 2022
@bdattoma bdattoma changed the title [Draft] Add tests for Data Science Projects page Add tests for Data Science Projects page Nov 15, 2022
@bdattoma bdattoma marked this pull request as ready for review November 15, 2022 18:29
@bdattoma
first files for DSG testing
19e4665 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add first 2 tests for project creation
958a492
@bdattoma
fix generic modal handling
77aa3a9
@bdattoma
add polarion ids
ed684de
@bdattoma
add check on NS creation
9ad6738
@bdattoma
add teardown to delete NS using OC
01486bb 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add workspace + delete all notebook from CLI
4334b08 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
minor variable name change
5abfca4 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add kw to wait for Dashboard spinner
4035274 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add workspace basic testing (to be finished)
3f40004 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
draft for template testing version
f21a4c4 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add generic cancel button
784b548 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add workspace v2 kw + new template
d27bdd9 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add workspace with PV storage testing
51881d1 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
minor changes
9e65d18 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
fix existing pv + add polarion ids
93c7fa0 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
fix prj selection in existing pv
e4dca43 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
fix prj selection in existing pv (2)
d54e84b 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
fix typo
6697c63 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add some dummy values
b11c771 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@lugi0
Copy link
Contributor

lugi0 commented Nov 17, 2022

@bdattoma I see a few failures in the dryrun, could you take a look?

==============================================================================
[ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_templates.robot' on line 5: Resource file '../../../Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workspaces.resource' does not exist.
Tests.Ods Dashboard.Ods Dashboard Projects.Ods Dashboard Projects Templates   
==============================================================================
Verify User Can Create A Data Science Project                         | FAIL |
Setup failed:
Keyword 'ODHDashboard.Launch Dashboard' expected 6 arguments, got 3.
------------------------------------------------------------------------------
Verify User Can Create A Workspace With Ephimeral Storage             | FAIL |
Setup failed:
Keyword 'ODHDashboard.Launch Dashboard' expected 6 arguments, got 3.
------------------------------------------------------------------------------
Verify User Can Create A Workspace With Persistent Storage            | FAIL |
Setup failed:
Keyword 'ODHDashboard.Launch Dashboard' expected 6 arguments, got 3.
------------------------------------------------------------------------------
Tests.Ods Dashboard.Ods Dashboard Projects.Ods Dashboard Projects ... | FAIL |
3 tests, 0 passed, 3 failed
==============================================================================
Tests.Ods Dashboard.Ods Dashboard Projects                            | FAIL |
23 tests, 20 passed, 3 failed
==============================================================================

@bdattoma
fix copy paste error
f2a5e35 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
Copy link
Contributor Author

@bdattoma I see a few failures in the dryrun, could you take a look?

==============================================================================
[ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects_templates.robot' on line 5: Resource file '../../../Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workspaces.resource' does not exist.
Tests.Ods Dashboard.Ods Dashboard Projects.Ods Dashboard Projects Templates   
==============================================================================
Verify User Can Create A Data Science Project                         | FAIL |
Setup failed:
Keyword 'ODHDashboard.Launch Dashboard' expected 6 arguments, got 3.
------------------------------------------------------------------------------
Verify User Can Create A Workspace With Ephimeral Storage             | FAIL |
Setup failed:
Keyword 'ODHDashboard.Launch Dashboard' expected 6 arguments, got 3.
------------------------------------------------------------------------------
Verify User Can Create A Workspace With Persistent Storage            | FAIL |
Setup failed:
Keyword 'ODHDashboard.Launch Dashboard' expected 6 arguments, got 3.
------------------------------------------------------------------------------
Tests.Ods Dashboard.Ods Dashboard Projects.Ods Dashboard Projects ... | FAIL |
3 tests, 0 passed, 3 failed
==============================================================================
Tests.Ods Dashboard.Ods Dashboard Projects                            | FAIL |
23 tests, 20 passed, 3 failed
==============================================================================

yeah but these are old

@bdattoma
fix robocp alerts
8fbe979 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
remove unused template file
bf47e3e 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
272 0 0 272 100

@bdattoma
fix robocop alerts
2f714a1 
Signed-off-by: bdattoma <bdattoma@redhat.com>
jgarciao
jgarciao reviewed Nov 22, 2022
View reviewed changes
lugi0
lugi0 previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments but as long as tests are passing lgtm

@bdattoma
Copy link
Contributor Author

bdattoma commented Nov 22, 2022 •
edited
Loading

Jenkins Job SUCCESS

lugi0
lugi0 previously approved these changes Nov 23, 2022
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jgarciao jgarciao self-requested a review November 23, 2022 10:03
jgarciao
jgarciao approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgarciao jgarciao merged commit 81f87cc into red-hat-data-services:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpouget kpouget kpouget left review comments

@jgarciao jgarciao jgarciao approved these changes

@lugi0 lugi0 lugi0 approved these changes

@tarukumar tarukumar Awaiting requested review from tarukumar

@aloganat aloganat Awaiting requested review from aloganat

@mwaykole mwaykole Awaiting requested review from mwaykole

@pablofelix pablofelix Awaiting requested review from pablofelix

Assignees

@bdattoma bdattoma

Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdattoma @lugi0 @jgarciao @kpouget