Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Data Science Pipelines tests to changes introduced by Pipeline Experiments #1576

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Adapt Data Science Pipelines tests to changes introduced by Pipeline Experiments #1576

merged 9 commits into from
Jun 28, 2024

Conversation

jgarciao
Copy link
Contributor

@jgarciao jgarciao commented Jun 28, 2024 •
edited
Loading

  • Fixes Pipelines UI test in Smoke and Elyra tests
  • Fixes bug in keyword Maybe Wait For Dashboard Spinner
  • Speeds up cloning operations in JupterLab
  • Tested successfully in rhods-ci-pr-test/3064 (Smoke and Sanity Elyra test, pending testing Tier1)

jgarciao added 4 commits June 28, 2024 16:04
@jgarciao
Fix Pipelines UI test in Smoke, adding experiments basic suppport
5da1e3b 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Fix elyra test due to changes in experiments
fcb7f05 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Speed up JupyterLab Git Clone deleting unnecessary wait
5426932 
Note: it was always waiting 60s, as the expected string never showed up

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Fix Maybe Wait For Dashboard Loading Spinner Page
544ea99 
It  was broken due to changes in the xpath

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 28, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot
... admin_username=${OCP_ADMIN_USER.USERNAME}
... username=${current_user}
... folder=${dir_name}
${status} ${err_msg} = Run Keyword and Ignore Error Clone Repo and Return Error Message ${REPO_URL}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Run Keyword and Ignore Error' does not follow case convention
ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot
... admin_username=${OCP_ADMIN_USER.USERNAME}
... username=${current_user}
... folder=${dir_name}
${status} ${err_msg} = Run Keyword and Ignore Error Clone Repo and Return Error Message ${REPO_URL}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Clone Repo and Return Error Message' does not follow case convention
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
496 0 0 496 100

@jiridanek jiridanek mentioned this pull request Jun 28, 2024
Closed
@jgarciao
Fix Delete Pipeline Server and other kw
561b620 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao jgarciao changed the title Adapt Data Science Pipelines tests for Experiments Adapt Data Science Pipelines tests to changes introduced by Pipeline Experiments Jun 28, 2024
@jgarciao
Fix experiment name
d1dbe62 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
jgarciao added 3 commits June 28, 2024 17:36
@jgarciao
Fix linter error
de1ef7c 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Parametrize experiment_name in Elyra testing
c90c476 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Fix formatting problems in DataSciencePipelinesKfp.py
48fd97b 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
jiridanek
jiridanek previously approved these changes Jun 28, 2024
View reviewed changes
@jiridanek jiridanek requested a review from harshad16 June 28, 2024 15:48
@jgarciao jgarciao added enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins labels Jun 28, 2024
@jgarciao jgarciao merged commit 133bbc6 into red-hat-data-services:master Jun 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiridanek jiridanek jiridanek approved these changes

@diegolovison diegolovison diegolovison approved these changes

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgarciao @jiridanek @diegolovison