-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-9157: check for a successful experiment instead of successful run #1569
Conversation
…l run In RHOAISTRAT-110, the Dashboard implemented support for Pipeline experiments. This changed the UI somewhat, so we need to check for the result of the Elyra pipeline in a slightly different place. Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Robot Results
|
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
code-wise, it seems good logic to check on experiments ran.
# robocop: disable:line-too-long | ||
Verify Experiment Has Completed | ||
[Documentation] Check that the "Last 5 runs" field of an "Experiments and runs" screen reports success | ||
[Arguments] ${experiment_name} ${pipeline_run_name} ${timeout}=10m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ${pipeline_run_name} is not being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I'd remove the parameter if I still wanted to use the keyword.
Select Pipeline Project By Name ${PRJ_TITLE} | ||
Log ${pipeline_run_name} | ||
Verify Pipeline Run Is Completed ${pipeline_run_name} timeout=5m | ||
Verify Experiment Has Completed standard data science pipeline ${pipeline_run_name} timeout=5m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think experiment name will be hello-generic-world
https://issues.redhat.com/browse/RHOAIENG-9157
In RHOAISTRAT-110, the Dashboard implemented support for Pipeline experiments. This changed the UI somewhat, so we need to check for the result of the Elyra pipeline in a slightly different place.
Jenkins: /job/rhods/job/rhods-ci-pr-test/3058/console
and here's the screenshot that the test takes
