Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-9157: check for a successful experiment instead of successful run #1569

Closed
wants to merge 4 commits into from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jun 28, 2024

https://issues.redhat.com/browse/RHOAIENG-9157

In RHOAISTRAT-110, the Dashboard implemented support for Pipeline experiments. This changed the UI somewhat, so we need to check for the result of the Elyra pipeline in a slightly different place.

Jenkins: /job/rhods/job/rhods-ci-pr-test/3058/console

and here's the screenshot that the test takes
image

…l run

In RHOAISTRAT-110,
the Dashboard implemented support for Pipeline experiments.
This changed the UI somewhat,
so we need
to check for the result of the Elyra pipeline in a slightly different place.

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
@jiridanek jiridanek added the needs testing Needs to be tested in Jenkins label Jun 28, 2024
@jiridanek jiridanek changed the title RHOAIENG-9157: Check for a successful experiment instead of successful run RHOAIENG-9157: check for a successful experiment instead of successful run Jun 28, 2024
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
496 0 0 496 100

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
@jiridanek jiridanek added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Jun 28, 2024
@jiridanek jiridanek enabled auto-merge (squash) June 28, 2024 13:15
@jiridanek jiridanek requested a review from harshad16 June 28, 2024 13:16
Copy link

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code-wise, it seems good logic to check on experiments ran.

# robocop: disable:line-too-long
Verify Experiment Has Completed
[Documentation] Check that the "Last 5 runs" field of an "Experiments and runs" screen reports success
[Arguments] ${experiment_name} ${pipeline_run_name} ${timeout}=10m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ${pipeline_run_name} is not being used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I'd remove the parameter if I still wanted to use the keyword.

Select Pipeline Project By Name ${PRJ_TITLE}
Log ${pipeline_run_name}
Verify Pipeline Run Is Completed ${pipeline_run_name} timeout=5m
Verify Experiment Has Completed standard data science pipeline ${pipeline_run_name} timeout=5m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think experiment name will be hello-generic-world

@jiridanek
Copy link
Member Author

jiridanek commented Jun 28, 2024

@jiridanek jiridanek closed this Jun 28, 2024
auto-merge was automatically disabled June 28, 2024 14:29

Pull request was closed

@jiridanek jiridanek deleted the jd_cleanups branch June 28, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants