Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Server dbExists temporary table fix #724

Merged
merged 7 commits into from
Jan 12, 2024
Merged

SQL Server dbExists temporary table fix #724

merged 7 commits into from
Jan 12, 2024

Conversation

meztez
Copy link
Contributor

@meztez meztez commented Jan 11, 2024

On SQL Server, dbExists does not take into account coexisting sessions.

See #719

@meztez meztez changed the title Fix #719 SQL Server dbExists temporary table fix Jan 11, 2024
@hadley
Copy link
Member

hadley commented Jan 11, 2024

Thanks for working on this! Would you mind adding a test too? The odbc testing infrastructure is currently a bit idiosyncratic, so feel free to write a test that works for you, and then I can get it working more generally.

@meztez
Copy link
Contributor Author

meztez commented Jan 11, 2024

Sure thing, added.
I assumed that con2 would create another distinct SQLSERVER session.

@hadley
Copy link
Member

hadley commented Jan 11, 2024

I guess we'll find out together soon!

@krlmlr krlmlr requested a review from detule January 11, 2024 22:18
@hadley
Copy link
Member

hadley commented Jan 11, 2024

Failures should be fixed by #722.

Copy link
Collaborator

@detule detule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants