Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DBItest failures #722

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Fix DBItest failures #722

merged 7 commits into from
Jan 12, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 11, 2024

R-devel failure is RcppCore/Rcpp#1290; nothing we can do about it, but Rcpp release should fix soon.

Copy link
Collaborator

@detule detule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@hadley hadley merged commit 7c38919 into main Jan 12, 2024
@hadley hadley deleted the dbi-test-fixes branch January 12, 2024 14:41
Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly skipped tests might work better with dev DBItest, soon on CRAN. It's worth revisiting them then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants