Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility issues with cirq dev #260

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Fix compatibility issues with cirq dev #260

merged 2 commits into from
Jun 8, 2022

Conversation

Strilanc
Copy link
Collaborator

@Strilanc Strilanc commented Jun 8, 2022

  • Also maintain compat with current version
  • Avoid measure key == qubit name due to circuit diagram change
  • Avoid implicit measure key from cirq.measure due to change in the default
  • Start using use_repetition_ids

Fixes #224

Strilanc added 2 commits June 8, 2022 00:51
@Strilanc
Fix compatibility issues with cirq dev
835f1c4 
- Also maintain compat with current version
- Avoid measure key == qubit name due to circuit diagram change
- Avoid implicit measure key from cirq.measure due to change in the default
- Start using `use_repetition_ids`
@Strilanc
Merge branch 'main' into rep
b408b06
@Strilanc Strilanc enabled auto-merge (squash) June 8, 2022 10:42
@Strilanc Strilanc merged commit 9c13f58 into main Jun 8, 2022
@Strilanc Strilanc deleted the rep branch June 8, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should Cirq translation of REPEAT set use_repetition_ids=False?
1 participant
@Strilanc