Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Cirq translation of REPEAT set use_repetition_ids=False? #224

Closed
daxfohl opened this issue Apr 11, 2022 · 3 comments · Fixed by #260
Closed

Should Cirq translation of REPEAT set use_repetition_ids=False? #224

daxfohl opened this issue Apr 11, 2022 · 3 comments · Fixed by #260

Comments

@daxfohl
Copy link

daxfohl commented Apr 11, 2022

In

Stim/glue/cirq/stimcirq/_stim_to_cirq.py

Line 124 in 4292824

repetitions=block.repeat_count,

We now have an option to ditch the repetition ids that get prepended to each measurement key. To my understanding, that should better reflect the Stim circuit. quantumlib/Cirq#4997
@Strilanc
Copy link
Collaborator

Makes sense to use this. It's in a released version of cirq now?

@Strilanc
Copy link
Collaborator

Currently blocked on quantumlib/Cirq#5418

@daxfohl
Copy link
Author

daxfohl commented Jun 7, 2022

The blocking issue was fixed by quantumlib/Cirq#5419

@Strilanc Strilanc mentioned this issue Jun 8, 2022
Merged
Strilanc added a commit that referenced this issue Jun 8, 2022
@Strilanc
Fix compatibility issues with cirq dev (#260)
9c13f58 
- Also maintain compat with current version
- Avoid measure key == qubit name due to circuit diagram change
- Avoid implicit measure key from cirq.measure due to change in the default
- Start using `use_repetition_ids`

Fixes #224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compatibility issues with cirq dev quantumlib/Stim
2 participants
@Strilanc @daxfohl