Check reservation status for a list of processors #140
Conversation
| for time_slot in processor.get_schedule(): | ||
| try: | ||
| time_slot = EngineTimeSlot.from_proto(time_slot) | ||
| # Parsing the end_time of the last time range in the schedule might give throw an error. |
There was a problem hiding this comment.
Is this expected? This seems like a problem. I am not sure we should just ignore ValueError blindly.
There was a problem hiding this comment.
It seems to be a problem in the EngineTimeSlot.from_proto function in cirq. For example, the end time of the last interval in the schedule has
end_time {
seconds: 253402300799
}
which raises ValueError: year 0 is out of range when trying to parse it with the datetime library.
There was a problem hiding this comment.
Ok, I will go and fix this in cirq. Let's add a TODO (and ideally, a github issue) to go back and fix this.
There was a problem hiding this comment.
Added a TODO, and created an issue in cirq: quantumlib/Cirq#3787
lingxz
force-pushed
the
reservation-status
branch
from
32b7e84 to
60e6985
Compare
| for time_slot in processor.get_schedule(): | ||
| try: | ||
| time_slot = EngineTimeSlot.from_proto(time_slot) | ||
| # Parsing the end_time of the last time range in the schedule might give throw an error. |
There was a problem hiding this comment.
Ok, I will go and fix this in cirq. Let's add a TODO (and ideally, a github issue) to go back and fix this.
* Add reservation status check function * Check reservation wip * Add tests for get_available_processors * Break lines in comments * Fix tests * Use the correct processor id and convert QuantumTimeSlot to EngineTimeSlot * address comments * Add test for other project id * Add TODO for time range parsing problem
quantumlib/unitary#50