Remove EngineTimeSlot #4608
Merged
Remove EngineTimeSlot #4608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It looks like this wrapper got created but never used. - It does not provide much value over the proto values directly, so I am just going to delete it. - This also fixes the typing which incorrectly says that the schedule is returned as a EngineTimeSlot, but it is actually a QuantumTimeSlot. While technically a breaking change, it would be quite surprising if anyone is dependent on this wrapper class, as it has never been used anywhere.
dstrain115
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
MichaelBroughton
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
This seems fine to me (in my travels with engine I never used this). If we want to go ahead and cut this without deprecating, would you mind adding the breaking_change label and a description of the break at the bottom of your PR description ?
cc: @mpharrigan
|
hello from cc land. Looks fine, although I agree this should be labeled with breaking change |
MichaelBroughton
added
BREAKING CHANGE
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
|
this actually broke a utility in recirq 🤦 |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- It looks like this wrapper got created but never used. - It does not provide much value over the proto values directly, so I am just going to delete it. - This also fixes the typing which incorrectly says that the schedule is returned as a EngineTimeSlot, but it is actually a QuantumTimeSlot. While technically a breaking change, it would be quite surprising if anyone is dependent on this wrapper class, as it has never been used anywhere. BREAKING CHANGE=Removed EngineTimeSlot without deprecation, (minimal to no usage).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so I am just going to delete it.
schedule is returned as a EngineTimeSlot, but it is actually a
QuantumTimeSlot.
While technically a breaking change, it would be quite surprising
if anyone is dependent on this wrapper class, as it has never been used
anywhere.
BREAKING CHANGE=Removed EngineTimeSlot without deprecation, (minimal to no usage).