-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FSimViaModelTag #6527
Merged
Merged
Add FSimViaModelTag #6527
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9f47225
Add FSimViaModelTag
BichengYing 543d09a
Add json resolver
BichengYing 1d9a4f7
Merge branch 'main' into u/ybc/fsim_model_tag
BichengYing d3d6598
Address the comment
BichengYing 5e3b526
Merge branch 'main' into u/ybc/fsim_model_tag
BichengYing 411638e
Merge branch 'main' into u/ybc/fsim_model_tag
BichengYing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"cirq_type": "FSimViaModelTag" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
cirq_google.FSimViaModelTag() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Copyright 2024 The Cirq Developers | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
"""A class that can be used to denote FSim gate implementation using polynomial model.""" | ||
from typing import Any, Dict | ||
|
||
import cirq | ||
|
||
|
||
class FSimViaModelTag: | ||
"""A tag class to denote FSim gate implementation using polynomial model. | ||
|
||
Without the tag, the translation of FSim gate implementation is possible only for a certain | ||
angles. For example, when theta=pi/2, phi=0, it translates into the same implementation | ||
as the SWAP gate. If FSimGate is tagged with this class, the translation will become | ||
a coupler gate that with proper coupler strength and coupler length via some polynomial | ||
modelling. Note not all combination of theta and phi in FSim gate are feasible and | ||
you need the calibration for these angle in advance before using them. | ||
""" | ||
|
||
def __str__(self) -> str: | ||
return 'FSimViaModelTag()' | ||
|
||
def __repr__(self) -> str: | ||
return 'cirq_google.FSimViaModelTag()' | ||
|
||
def _json_dict_(self) -> Dict[str, Any]: | ||
return cirq.obj_to_dict_helper(self, []) | ||
|
||
def __eq__(self, other) -> bool: | ||
return isinstance(other, FSimViaModelTag) | ||
|
||
def __hash__(self) -> int: | ||
return hash("FSimViaModelTag") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# Copyright 2024 The Cirq Developers | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
import cirq | ||
import cirq_google | ||
|
||
|
||
def test_equality(): | ||
assert cirq_google.FSimViaModelTag() == cirq_google.FSimViaModelTag() | ||
assert hash(cirq_google.FSimViaModelTag()) == hash(cirq_google.FSimViaModelTag()) | ||
|
||
|
||
def test_str_repr(): | ||
assert str(cirq_google.FSimViaModelTag()) == 'FSimViaModelTag()' | ||
assert repr(cirq_google.FSimViaModelTag()) == 'cirq_google.FSimViaModelTag()' | ||
cirq.testing.assert_equivalent_repr( | ||
cirq_google.FSimViaModelTag(), setup_code=('import cirq\nimport cirq_google\n') | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Would it make sense to be more specific in the name, e.g.
FSimViaPolyModelTag
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FSimViaModel
is also the name used in the pyle. (I wish I thought twice on this name). But maybe withoutPoly
is preferred -- in case we have other modeling approach to do the implementation in the future.