Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FSimViaModelTag #6527

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Conversation

BichengYing
Copy link
Collaborator

@BichengYing BichengYing commented Mar 26, 2024

The motivation of creating this tag is for the qcc/translate part. We can use this tag to control which implementation gate we want to translate it into.

CC: @maffoo @eliottrosenberg

@BichengYing BichengYing requested review from wcourtney, vtomole, cduck, verult and a team as code owners March 26, 2024 19:51
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (e5ad426) to head (5e3b526).
Report is 3 commits behind head on main.

❗ Current head 5e3b526 differs from pull request most recent head 411638e. Consider uploading reports for the commit 411638e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6527   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files        1105     1107    +2     
  Lines       95154    95178   +24     
=======================================
+ Hits        93045    93069   +24     
  Misses       2109     2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Bicheng!

import cirq


class FSimViaModelTag:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Would it make sense to be more specific in the name, e.g. FSimViaPolyModelTag?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FSimViaModel is also the name used in the pyle. (I wish I thought twice on this name). But maybe without Poly is preferred -- in case we have other modeling approach to do the implementation in the future.

@verult verult enabled auto-merge (squash) March 29, 2024 20:53
@verult verult merged commit fc3cc70 into quantumlib:main Mar 29, 2024
29 checks passed
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
* Add FSimViaModelTag

* Add json resolver

* Address the comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants