-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FSimViaModelTag #6527
Add FSimViaModelTag #6527
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6527 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 1105 1107 +2
Lines 95154 95178 +24
=======================================
+ Hits 93045 93069 +24
Misses 2109 2109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Bicheng!
import cirq | ||
|
||
|
||
class FSimViaModelTag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Would it make sense to be more specific in the name, e.g. FSimViaPolyModelTag
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FSimViaModel
is also the name used in the pyle. (I wish I thought twice on this name). But maybe without Poly
is preferred -- in case we have other modeling approach to do the implementation in the future.
* Add FSimViaModelTag * Add json resolver * Address the comment
The motivation of creating this tag is for the qcc/translate part. We can use this tag to control which implementation gate we want to translate it into.
CC: @maffoo @eliottrosenberg