CI - add job for shellcheck #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `file` utility to find shell scripts in the repository.
viathor
approved these changes
Nov 11, 2022
| check/mypy | ||
| check/nbformat | ||
| check/pylint | ||
| check/pytest |
There was a problem hiding this comment.
No action needed: Eventually, we can add shellcheck itself ;-)
There was a problem hiding this comment.
It should be already included. :-) This list is to verify the shell scripts search command (ie, git ls-files ... | xargs file | ...) works as expected. Would be disappointing to have a passing check that checks zero files. :-/
There was a problem hiding this comment.
I understand why you've done it and I think it's a great sanity check. I just meant to say that the sanity check could be self-referential since as you say git ls-files invoked by shellcheck should find shellcheck itself :-)
viathor
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: Failed to update branch (incorrect expected_head_sha). |
CirqBot
removed
the
automerge
viathor
added
the
automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Add check/shellcheck for syntax checking of shell scripts - Add CI job to run shellcheck on our shell scripts Resolves quantumlib#5923.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5923.