Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - check shell scripts with shellcheck #5923

Closed
pavoljuhas opened this issue Oct 14, 2022 · 0 comments · Fixed by #5948
Closed

CI - check shell scripts with shellcheck #5923

pavoljuhas opened this issue Oct 14, 2022 · 0 comments · Fixed by #5948
Assignees
@pavoljuhas
Labels
area/ci kind/health For CI/testing/release process/refactoring/technical debt items triage/discuss Needs decision / discussion, bring these up during Cirq Cynque

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

#5910 fixed issues in shell scripts discovered by shellcheck.
We should add an automated CI check to keep scripts healthy in the future.

Cirq version

1.1.0.dev at 6e64449
@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Oct 14, 2022
@viathor viathor added triage/discuss Needs decision / discussion, bring these up during Cirq Cynque area/ci labels Nov 8, 2022
@pavoljuhas pavoljuhas self-assigned this Nov 9, 2022
@pavoljuhas pavoljuhas mentioned this issue Nov 10, 2022
Merged
CirqBot pushed a commit that referenced this issue Nov 12, 2022
@pavoljuhas
CI - add job for shellcheck (#5948)
f888f8d 
- Add check/shellcheck for syntax checking of shell scripts
- Add CI job to run shellcheck on our shell scripts

Resolves #5923.
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@pavoljuhas @rht
CI - add job for shellcheck (quantumlib#5948)
878d439 
- Add check/shellcheck for syntax checking of shell scripts
- Add CI job to run shellcheck on our shell scripts

Resolves quantumlib#5923.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavoljuhas pavoljuhas

Labels
area/ci kind/health For CI/testing/release process/refactoring/technical debt items triage/discuss Needs decision / discussion, bring these up during Cirq Cynque
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI - add job for shellcheck pavoljuhas/Cirq
2 participants
@pavoljuhas @viathor