Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efficient 2q state preparation methods using CZ and SQRT_ISWAP #4707
Efficient 2q state preparation methods using CZ and SQRT_ISWAP #4707
Changes from all commits
5926de9
3a36d2d
cd97a04
f4a5ec4
63eeefc
e9750cf
49528a0
33629fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
to_valid_state_vector
doesn't normalize for us ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it just does the appropriate type conversions for us. It also validates (up to atol) that the given state vector is normalized by
np.isclose(np.sum(np.abs(state_vector) ** 2), 1)
but explicitly normalizing the state vector again improves numerical accuracy (tests fail if I remove the normalization line).