Efficient 2q state preparation methods using CZ and SQRT_ISWAP #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+55
to
+56
| state = qis.to_valid_state_vector(state, num_qubits=2) | ||
| state = state / np.linalg.norm(state) |
There was a problem hiding this comment.
Question: to_valid_state_vector doesn't normalize for us ?
There was a problem hiding this comment.
No, it just does the appropriate type conversions for us. It also validates (up to atol) that the given state vector is normalized by np.isclose(np.sum(np.abs(state_vector) ** 2), 1) but explicitly normalizing the state vector again improves numerical accuracy (tests fail if I remove the normalization line).
|
@MichaelBroughton I've addressed the comments. PTAL. |
…instead of hardcoding
MichaelBroughton
approved these changes
Dec 2, 2021
|
@MichaelBroughton Opened another issue to track the general case. I'll merge this one for now. |
thanacles
pushed a commit
to thanacles/Cirq
that referenced
this pull request
Dec 11, 2021
…antumlib#4707) * merge_operations and merge_moments transformer primitives * Refactor to use features compatible with python3.6 * Add complexity tests for merge_operations * Add iteration info to the docstring
MichaelBroughton
pushed a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
…lytical_decompositions/two_qubit_state_preparation.py` (quantumlib#4762) Part of quantumlib#4722 This is safe to do without going through a deprecation cycle because `optimizers/two_qubit_state_preparation.py ` was recently introduced (quantumlib#4707) in the current dev version and hasn't been released yet.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…umlib#4707) * Two qubit state preparation using sqrt(iswap) and cz * Improve numerical accuracy and additional improvements * Use circuit.final_state_vector to populate intermediate state matrix instead of hardcoding
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…lytical_decompositions/two_qubit_state_preparation.py` (quantumlib#4762) Part of quantumlib#4722 This is safe to do without going through a deprecation cycle because `optimizers/two_qubit_state_preparation.py ` was recently introduced (quantumlib#4707) in the current dev version and hasn't been released yet.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…umlib#4707) * Two qubit state preparation using sqrt(iswap) and cz * Improve numerical accuracy and additional improvements * Use circuit.final_state_vector to populate intermediate state matrix instead of hardcoding
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…lytical_decompositions/two_qubit_state_preparation.py` (quantumlib#4762) Part of quantumlib#4722 This is safe to do without going through a deprecation cycle because `optimizers/two_qubit_state_preparation.py ` was recently introduced (quantumlib#4707) in the current dev version and hasn't been released yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds methods to efficiently prepare any arbitrary 2q state from the
|00>by applying at-most one 2q entangling gate (CZ/sqrt_iswap).The methods along with the new
map_operationsprimitive can be used to replace thecirq.StatePreparationChannelwith the optimal operations preparing that state (under the assumption that initial state is|00>).Fixes #4500