-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circuit superoperator #4550
Merged
Merged
Circuit superoperator #4550
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e46c972
Circuit superoperator
viathor 08ad346
Merge branch 'master' into circuit_superoperator
viathor 019b0fb
Merge branch 'master' into circuit_superoperator
viathor 2a3e50c
_kraus_ and _superoperator_ for cirq.Moment
viathor 2d04709
Formmat
viathor ca9518f
docstring
viathor b2762c7
Merge branch 'master' into circuit_superoperator
viathor 25bc94f
pylint
viathor 99bc1df
rrrrrrr
viathor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some more details to the docstring? For example, a mention that the method performs parallel concatenation of kraus operators of the individual operations ?
Also, do you think it would be useful to have methods in
cirq/qis/channels
for serial and parallel concatenation of mixtures and kraus operators, which can be useful general primitives?The parallel concatenation method can be used here and the serial concatenation method can be used in the kraus/mixture protocol methods while computing operators of an operation using the operators of it's decomposed operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re docstring: Done.
Re composition: Composing Kraus representations (in series or in parallel) is cumbersome because it results in a representation with a very large number of Kraus operators. We should avoid it whenever possible. For serial composition we can always(*) avoid it by using superoperator representation instead. For parallel composition all our channel representations are cumbersome (e.g. superoperator becomes a very large matrix). However, we can still describe channels using circuits which avoids the issue. Thus, we should not need to compute serial composition of Kraus representations (else we're doing it wrong) and we should only compute parallel composition in the context of a circuit moment. For this reason, I'd rather we don't implement serial composition of Kraus representations at all and keep the code for parallel composition in
Moment._kraus_
.(*) It's interesting how parallel (or causally independent) composition preserves all the details of the composed processes preventing us from compressing it while serial (or causally connected) composition loses some information about what's going on enabling a compressed description. This observation has inspired a lot of cool ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW: Note that #4486 concerns serial composition only. Thus, we will be able to solve the issues encountered there once this PR and #4545 are merged since then we'll have access to fully supported superoperator representation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for the explanation!