Superoperator protocol #4545
Closed
Superoperator protocol #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
reviewed
Oct 4, 2021
Comment on lines
+115
to
+118
| so_getter = getattr(val, '_superoperator_', None) | ||
| so_result = NotImplemented if so_getter is None else so_getter() | ||
| if so_result is not NotImplemented: | ||
| return so_result |
There was a problem hiding this comment.
Similar to the bugs in kraus and mixture, this will also not work well with decompose. For example:
class A(cirq.SingleQubitGate):
def _superoperator_(self):
return self.super_op
class B(cirq.TwoQubitGate):
def _decompose_(self, qubits):
return [A().on(q) for q in qubits]To support constructing superoperator of B using superoperator of A, we'll need to implement the logic which looks at the decomposed operations and their corresponding cirq.superoperator(op) and uses them to reconstruct the super operator of val.
This was left out as part of implementing kraus and mixture and these bugs are currently being fixed in #4486.
Can you please add the logic of combining superoperators of decomposed operation to reconstruct the superoperator of the current operation? If not, can we document that recursive reconstruction is not supported?
Merged
mhucka
added
the
status/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.