Code Quality Fixes in StatePreparationChannel #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed many of the nits mentioned in quantumlib#4482, value-equality not a part of this commit.
AnimeshSinha1309
requested review from
cduck,
vtomole and
a team
as code owners
AnimeshSinha1309
changed the title
|
@tanujkhattar I don't know how to use ValueEquality, because then I am forced to specify an exact comparison value, which does not exist. It makes the test |
State Preparation Channel got equality comparison similar to that of Matrix Gate.
|
Without getting |
tanujkhattar
requested changes
Sep 17, 2021
name parameter added to constructor, JSON, and repr serialization as well as test data.
The name has been changed in the JSON and repr protocol tests to make the older version fail.
Had to run pylint.
tanujkhattar
approved these changes
Sep 27, 2021
Two gates with different names are still equal, added tests for that.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Fixing Minor Errors Fixed many of the nits mentioned in quantumlib#4482, value-equality not a part of this commit. * Approx Equality support added State Preparation Channel got equality comparison similar to that of Matrix Gate. * Added name parameter to state preparation channel name parameter added to constructor, JSON, and repr serialization as well as test data. * Custom names in serialization tests The name has been changed in the JSON and repr protocol tests to make the older version fail. * Format and Lint Fix Had to run pylint. * Adding tests to ignore name Two gates with different names are still equal, added tests for that.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Fixing Minor Errors Fixed many of the nits mentioned in quantumlib#4482, value-equality not a part of this commit. * Approx Equality support added State Preparation Channel got equality comparison similar to that of Matrix Gate. * Added name parameter to state preparation channel name parameter added to constructor, JSON, and repr serialization as well as test data. * Custom names in serialization tests The name has been changed in the JSON and repr protocol tests to make the older version fail. * Format and Lint Fix Had to run pylint. * Adding tests to ignore name Two gates with different names are still equal, added tests for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the comments made in #4482
This pull request fixes some of the code quality issues that were created in the previous pull request.