Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable serialization of CircuitOperations #4380

Closed

Conversation

95-martin-orion
Copy link
Collaborator

@95-martin-orion 95-martin-orion commented Aug 3, 2021

This is a combined roll-forward of #4336 and #4344. Part of #3634.

Additional changes in this PR that were not in the originals:

Next steps:

  • Push changes to servers. This remains compatible: checks in get_device only care that the local gatesets can be found in the processor proto, and the new proto is a superset of the previous proto.
  • Clean up non-circuitop gatesets and re-push. Removing the old gatesets is a local change, only affecting the internal naming of gatesets (e.g. XMON vs XMON_WITH_CIRCUITOP)

Known weirdness:

  • Serialized gate_set_names will permanently have a trailing _co after this change (e.g. 'xmon_co' instead of 'xmon') The only way around this is to double the number of steps, at which point a temporary breakage seems preferable.

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 3, 2021
@CirqBot CirqBot added size: XL lines changed >1000 size: M 50< lines changed <250 and removed size: XL lines changed >1000 labels Aug 12, 2021
@95-martin-orion
Copy link
Collaborator Author

Discussed offline with @maffoo - there is a preferred process for handling backwards-compatible changes to gatesets which we will implement instead of this change. Closing in favor of that method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining. size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants