Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CircuitOp serialization. #4344

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

95-martin-orion
Copy link
Collaborator

This PR adds CircuitOperation serializers to the default gateset used in QCS. After it is submitted, CircuitOperations sent to QCS will be serialized in a compact format, reducing the size of highly-repetitive circuits.

Not included in this PR:

@95-martin-orion 95-martin-orion requested review from cduck, vtomole, wcourtney and a team as code owners July 21, 2021 14:13
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jul 21, 2021
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think it's worth including a few more gates from each gateset in the tests ?

@95-martin-orion
Copy link
Collaborator Author

Do you think it's worth including a few more gates from each gateset in the tests ?

Not really - other gates are already tested pretty thoroughly in this file, and nesting a gate in CircuitOperation doesn't affect how it gets serialized. More complex behavior, like nesting of CircuitOperations, is tested in the serializer itself.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 21, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 21, 2021
@CirqBot CirqBot merged commit 4d956c5 into quantumlib:master Jul 21, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 21, 2021
@95-martin-orion 95-martin-orion deleted the cirq-enable-cop-serial-1 branch July 21, 2021 18:14
95-martin-orion added a commit that referenced this pull request Jul 26, 2021
CirqBot pushed a commit that referenced this pull request Jul 26, 2021
Reverts #4344.

Enabling CircuitOp serialization is causing errors in QCS.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
This PR adds `CircuitOperation` serializers to the default gateset used in QCS. After it is submitted, `CircuitOperation`s sent to QCS will be serialized in a compact format, reducing the size of highly-repetitive circuits.

Not included in this PR:
* Support for `CircuitOperation`s in `cirq.optimized_for_sycamore` (to be added in quantumlib#4336)
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Reverts quantumlib#4344.

Enabling CircuitOp serialization is causing errors in QCS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants