-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CircuitOp serialization. #4344
Enable CircuitOp serialization. #4344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you think it's worth including a few more gates from each gateset in the tests ?
Not really - other gates are already tested pretty thoroughly in this file, and nesting a gate in |
This reverts commit 4d956c5.
Reverts #4344. Enabling CircuitOp serialization is causing errors in QCS.
This PR adds `CircuitOperation` serializers to the default gateset used in QCS. After it is submitted, `CircuitOperation`s sent to QCS will be serialized in a compact format, reducing the size of highly-repetitive circuits. Not included in this PR: * Support for `CircuitOperation`s in `cirq.optimized_for_sycamore` (to be added in quantumlib#4336)
Reverts quantumlib#4344. Enabling CircuitOp serialization is causing errors in QCS.
This PR adds
CircuitOperation
serializers to the default gateset used in QCS. After it is submitted,CircuitOperation
s sent to QCS will be serialized in a compact format, reducing the size of highly-repetitive circuits.Not included in this PR:
CircuitOperation
s incirq.optimized_for_sycamore
(to be added in Allow CircuitOperations in cirq.optimized_for_sycamore #4336)