Reverts parts of 35d62ab relative to raster layer properties

[DelazJ]

refs #39693
35d62ab was fixing some visual issues that are worth a fix so I did not revert the whole commit but if required it's possible here (I didn't want to trigger an unnecessary(?) PR)

[nirvn]

@luipir , since you're able to replicate crash, can you confirm this partial revert is sufficient and the crash is gone?

[luipir]

@luipir , since you're able to replicate crash, can you confirm this partial revert is sufficient and the crash is gone?

I'll do tomorrow...thanks

[luipir]

@DelazJ first test cherry-piking your two commits 634d8bf2c652894e398bac22989e94b3ef5838fd and e3e2577097e4507344c39e455ea52a09d4fb44e6 applied on fd9b11d (upstream/release-3_16) does not solve the issue... I'll try to do a complete revert of that commit

[nirvn]

At this stage, I'd vote for a complete reversal for 3.16.1 (and master), then re-apply bits one by one to figure out what is wrong.

[luipir]

a compete revert of 35d62ab on fcafb27 (upstream/release-3_16) solve the issue :|

[alexbruy]

Were the same adjustments made in the Options dialog? I have repeated crashes when try to open Options dialog.

Looks like #39075 should be reverted completely.

[luipir]

Were the same adjustments made in the Options dialog? I have repeated crashes when try to open Options dialog.

Looks like #39075 should be reverted completely.

I tested opening option dialog and raster symbology in option dialog... after revert only of 35d62ab. Not idea why the other commit does not affect the crash

[nirvn]

@luipir , to avoid confusion, am I understanding you correctly in that by only reverting 35d62ab , the crashes are gone?

[luipir]

@luipir , to avoid confusion, am I understanding you correctly in that by only reverting 35d62ab , the crashes are gone?

correct... a complete revert not a partial one as proposed in your first PR

[luipir]

Were the same adjustments made in the Options dialog? I have repeated crashes when try to open Options dialog.

Looks like #39075 should be reverted completely.

@alexbruy would be great if you were able to confirm that crash goes away with a total rever or with the new proposed PR. The reason is to be sure that crash is not due to some local effect of my setup.

[nyalldawson]

Closing given #39935 is a better fix